Don't leak the list store. (#148134, Crispin Flowerday)

	* gtk/gtkcombobox.c (gtk_combo_box_new_text): Don't leak the
	list store.  (#148134, Crispin Flowerday)

diff --git a/ChangeLog b/ChangeLog
index 1bb558ca312a3f1196f67d4f0acfdab5324cb628..c6fde93b197e6605528a7c405cc5961dc396457f 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,6 +1,11 @@
+Wed Jul 21 22:46:27 2004  Matthias Clasen  <maclas@gmx.de>
+
+       * gtk/gtkcombobox.c (gtk_combo_box_new_text): Don't leak the
+       list store.  (#148134, Crispin Flowerday)
+
 Wed Jul 21 22:35:47 2004  Matthias Clasen  <maclas@gmx.de>
 
-       * gtk/gtkcellview.c (gtk_cell_view_finalize): Don't leak the
+       * gtk/gtkcombobox.c (gtk_combo_box_destroy): Don't leak the
        menu.  (#148110, Tommi Komulainen)
 
 Wed Jul 21 22:24:10 2004  Matthias Clasen  <maclas@gmx.de>

diff --git a/ChangeLog.pre-2-10 b/ChangeLog.pre-2-10
index 1bb558ca312a3f1196f67d4f0acfdab5324cb628..c6fde93b197e6605528a7c405cc5961dc396457f 100644 (file)
--- a/ChangeLog.pre-2-10
+++ b/ChangeLog.pre-2-10
@@ -1,6 +1,11 @@
+Wed Jul 21 22:46:27 2004  Matthias Clasen  <maclas@gmx.de>
+
+       * gtk/gtkcombobox.c (gtk_combo_box_new_text): Don't leak the
+       list store.  (#148134, Crispin Flowerday)
+
 Wed Jul 21 22:35:47 2004  Matthias Clasen  <maclas@gmx.de>
 
-       * gtk/gtkcellview.c (gtk_cell_view_finalize): Don't leak the
+       * gtk/gtkcombobox.c (gtk_combo_box_destroy): Don't leak the
        menu.  (#148110, Tommi Komulainen)
 
 Wed Jul 21 22:24:10 2004  Matthias Clasen  <maclas@gmx.de>

diff --git a/ChangeLog.pre-2-6 b/ChangeLog.pre-2-6
index 1bb558ca312a3f1196f67d4f0acfdab5324cb628..c6fde93b197e6605528a7c405cc5961dc396457f 100644 (file)
--- a/ChangeLog.pre-2-6
+++ b/ChangeLog.pre-2-6
@@ -1,6 +1,11 @@
+Wed Jul 21 22:46:27 2004  Matthias Clasen  <maclas@gmx.de>
+
+       * gtk/gtkcombobox.c (gtk_combo_box_new_text): Don't leak the
+       list store.  (#148134, Crispin Flowerday)
+
 Wed Jul 21 22:35:47 2004  Matthias Clasen  <maclas@gmx.de>
 
-       * gtk/gtkcellview.c (gtk_cell_view_finalize): Don't leak the
+       * gtk/gtkcombobox.c (gtk_combo_box_destroy): Don't leak the
        menu.  (#148110, Tommi Komulainen)
 
 Wed Jul 21 22:24:10 2004  Matthias Clasen  <maclas@gmx.de>

diff --git a/ChangeLog.pre-2-8 b/ChangeLog.pre-2-8
index 1bb558ca312a3f1196f67d4f0acfdab5324cb628..c6fde93b197e6605528a7c405cc5961dc396457f 100644 (file)
--- a/ChangeLog.pre-2-8
+++ b/ChangeLog.pre-2-8
@@ -1,6 +1,11 @@
+Wed Jul 21 22:46:27 2004  Matthias Clasen  <maclas@gmx.de>
+
+       * gtk/gtkcombobox.c (gtk_combo_box_new_text): Don't leak the
+       list store.  (#148134, Crispin Flowerday)
+
 Wed Jul 21 22:35:47 2004  Matthias Clasen  <maclas@gmx.de>
 
-       * gtk/gtkcellview.c (gtk_cell_view_finalize): Don't leak the
+       * gtk/gtkcombobox.c (gtk_combo_box_destroy): Don't leak the
        menu.  (#148110, Tommi Komulainen)
 
 Wed Jul 21 22:24:10 2004  Matthias Clasen  <maclas@gmx.de>

diff --git a/gtk/gtkcombobox.c b/gtk/gtkcombobox.c
index 4520e27c98f30e2fd24f72e5d9e5ba326081c1df..e28b965c3b8fb9721e6c2c431404c022329adf56 100644 (file)
--- a/gtk/gtkcombobox.c
+++ b/gtk/gtkcombobox.c
@@ -3825,8 +3825,8 @@ gtk_combo_box_new_text (void)
   GtkListStore *store;
 
   store = gtk_list_store_new (1, G_TYPE_STRING);
-
   combo_box = gtk_combo_box_new_with_model (GTK_TREE_MODEL (store));
+  g_object_unref (store);
 
   cell = gtk_cell_renderer_text_new ();
   gtk_cell_layout_pack_start (GTK_CELL_LAYOUT (combo_box), cell, TRUE);